Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding migration script adding i_query index #2578

Merged
merged 6 commits into from
Apr 15, 2024

Conversation

gabrielmer
Copy link
Contributor

@gabrielmer gabrielmer commented Apr 9, 2024

Description

Creating new i_query index for the postgres db, which is currently added only in sqlite

Changes

  • adding new migration script adding the index
  • updating schema version
  • fixing error log when i_query index creation fails in sqlite
image

Issue

closes #2357

Copy link

github-actions bot commented Apr 9, 2024

This PR may contain changes to database schema of one of the drivers.

If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues.

Please make sure the label release-notes is added to make sure upgrade instructions properly highlight this change.

Copy link

github-actions bot commented Apr 9, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2578-rln-v2-false

Built from 563a2fd

@gabrielmer gabrielmer self-assigned this Apr 10, 2024
@gabrielmer gabrielmer marked this pull request as ready for review April 10, 2024 07:46
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looooks just fine! Thank you!

@gabrielmer gabrielmer merged commit 4117fe6 into master Apr 15, 2024
13 of 15 checks passed
@gabrielmer gabrielmer deleted the chore-adding-postgres-index branch April 15, 2024 09:57
gabrielmer added a commit that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: i_query is not created by the node on database init
3 participants