bug: PeerInfo instance affects listed protocols

[AlejandroCabeza]

Problem

The order in which protocols are mounted, nodes are started, and peerInfo is retrieved; matters for peerInfo.protocols consistency

Impact

Low

To reproduce

The simplest way to reproduce is to checkout the test-peer-connection-management branch. Open tests/node/test_wakunode_peer_manager.nim and check out the Mount Order suite. In there there's a test case for each of the order possibilities. In the last two (info-start-protocol, info-protocol-start) the peerInfo is not updated with the correct protocols.

Expected behavior

Not sure if this is expected or not.

nwaku version/commit hash

• wakunode2: v0.24.0-rc.0-126-g4117fe
• branch: test-peer-connection-management
• commit: bbebbac (might change in the future)