Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: ENR shouldn't be used for pruning #2594

Open
AlejandroCabeza opened this issue Apr 16, 2024 · 0 comments
Open

bug: ENR shouldn't be used for pruning #2594

AlejandroCabeza opened this issue Apr 16, 2024 · 0 comments
Labels
bug Something isn't working effort/days Estimated to be completed in a few days, less than a week

Comments

@AlejandroCabeza
Copy link
Contributor

AlejandroCabeza commented Apr 16, 2024 •
edited

Problem

PeerManager.prunePeer should not use ENR as it's easy to fake.

Impact

Low

To reproduce

https://github.com/waku-org/nwaku/blob/master/waku/node/peer_manager/peer_manager.nim#L852-L853

Expected behavior

Instead of ENR, GossipSub.peerStats could be an option.

nwaku version/commit hash

wakunode2: v0.24.0-rc.0-126-g4117fe
branch: test-peer-connection-management
commit: bbebbac (might change in the future)

CC: @alrevuelta
@AlejandroCabeza AlejandroCabeza added the bug Something isn't working label Apr 16, 2024
@gabrielmer gabrielmer added the effort/days Estimated to be completed in a few days, less than a week label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working effort/days Estimated to be completed in a few days, less than a week
Projects
Waku
Status: To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlejandroCabeza @gabrielmer