Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: store v3 does not detect invalid cursor #2634

Closed
SionoiS opened this issue Apr 25, 2024 · 2 comments
Closed

bug: store v3 does not detect invalid cursor #2634

SionoiS opened this issue Apr 25, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@SionoiS
Copy link
Contributor

SionoiS commented Apr 25, 2024

@richard-ramos found this. Noted here for tracking.

Request

{"request_id":"e8f5d59a0cb3989fd908a3ae133a4fc8610926be2ccd95b0356c23d1761bc23e","return_values":true,"pubsub_topic":"/waku/2/default-waku/proto","content_topics":["test"],"time_start":1714077326654600248,"time_end":1714077326757556513,"pagination_cursor":"AQIDBAUG","pagination_forward":true,"pagination_limit":20}

Response

{"request_id":"e8f5d59a0cb3989fd908a3ae133a4fc8610926be2ccd95b0356c23d1761bc23e","status_code":200,"status_desc":"OK","messages":[{"message_hash":"mdzTZ0K3Cdc4oYdGyWKrHsxSrVGAOFe8q3VTJPUp85Y=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714077326654601367","meta":"","ephemeral":false,"rateLimitProof":""}},{"message_hash":"V+hJQFGftpMUofp2vsWUVuCEbg7emwn6kaONRp1sduk=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714077326675208887","meta":"","ephemeral":false,"rateLimitProof":""}},{"message_hash":"1kEsjM9z77NKt3tqUb2sacFDQo4Fj/4rHGCpunyZiFU=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714077326695847050","meta":"","ephemeral":false,"rateLimitProof":""}},{"message_hash":"302racfJCUlX+i8A3SGhIotWBmPeRMHMU6m+TDbCuX8=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714077326716404024","meta":"","ephemeral":false,"rateLimitProof":""}},{"message_hash":"dCR1B7q9eBNEJ0MSvdqnRbJKXY446wLsLunNVgBHFZM=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714077326736835722","meta":"","ephemeral":false,"rateLimitProof":""}}]}

It should reject invalid cursor like this.

@SionoiS SionoiS added the bug Something isn't working label Apr 25, 2024
@SionoiS SionoiS self-assigned this Apr 25, 2024
@Ivansete-status
Copy link
Collaborator

@SionoiS - is this issue related to that one? #2653

@SionoiS
Copy link
Contributor Author

SionoiS commented Apr 30, 2024

@SionoiS - is this issue related to that one? #2653

This one check the length of the cursor the other if it is present in the db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants