chore: update readme, do not rely on msg being plaintext #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivansete-status
approved these changes
Feb 9, 2024
| NODEKEY=$(openssl rand -hex 32) | ||
| ``` | ||
|
|
||
| You car run the `tests/waku_example.py` now as |
There was a problem hiding this comment.
Tiny typo. But the weird thing is that 'n' and 'r' are not next to each other hehe xD
Suggested change
| You car run the `tests/waku_example.py` now as | |
| You can run the `tests/waku_example.py` now as |
| try: | ||
| msgPlain = msg.decode('utf-8') | ||
| except: | ||
| msgPlain = "[binary content]" |
There was a problem hiding this comment.
I wonder if we could append somehow the exception detail
There was a problem hiding this comment.
Well, the exception is something like "Failed to decode because...", but it is not really useful because we know what the problem is - the msg is in binary format, not plaintext utf-8, so I just wanted to give that note to the user, but the main point is that the message got delivered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bit of "how to run the example" into the README and fixes one issue I hit while running the example - when binary (protobuf encoded) messages appear, the py-waku will fail to decode them as utf-8, we should leave decoding to the app (callback) rather than assume plaintext is used