Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(WakuRlnRegistry): uups proxy #9

Merged
merged 2 commits into from
Sep 11, 2023
Merged

feat(WakuRlnRegistry): uups proxy #9

merged 2 commits into from
Sep 11, 2023

Conversation

rymnc
Copy link
Collaborator

@rymnc rymnc commented Sep 5, 2023

Uses OZ's UUPS proxy to deploy the WakuRlnRegistry

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

LCOV of commit 1411f81 during CI #23

Summary coverage rate:
  lines......: 84.2% (32 of 38 lines)
  functions..: 76.9% (10 of 13 functions)
  branches...: 66.7% (12 of 18 branches)

Files changed coverage rate:
                               |Lines       |Functions  |Branches    
  Filename                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================
  contracts/WakuRlnRegistry.sol|81.0%     21|71.4%     7|66.7%     12

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

LCOV of commit e3defaf during CI #24

Summary coverage rate:
  lines......: 84.2% (32 of 38 lines)
  functions..: 76.9% (10 of 13 functions)
  branches...: 66.7% (12 of 18 branches)

Files changed coverage rate:
                               |Lines       |Functions  |Branches    
  Filename                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================
  contracts/WakuRlnRegistry.sol|81.0%     21|71.4%     7|66.7%     12

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

LCOV of commit 063f072 during CI #25

Summary coverage rate:
  lines......: 84.2% (32 of 38 lines)
  functions..: 76.9% (10 of 13 functions)
  branches...: 66.7% (12 of 18 branches)

Files changed coverage rate:
                               |Lines       |Functions  |Branches    
  Filename                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================
  contracts/WakuRlnRegistry.sol|81.0%     21|71.4%     7|66.7%     12

@rymnc rymnc marked this pull request as ready for review September 5, 2023 17:22
@rymnc rymnc self-assigned this Sep 5, 2023
@rymnc rymnc requested a review from 0x-r4bbit September 5, 2023 17:45
0x-r4bbit
0x-r4bbit approved these changes Sep 6, 2023
View reviewed changes
contracts/WakuRlnRegistry.sol Show resolved Hide resolved
@rymnc rymnc merged commit 19fded8 into main Sep 11, 2023
1 check passed
@rymnc rymnc deleted the uups-proxy branch September 11, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x-r4bbit 0x-r4bbit 0x-r4bbit approved these changes

Assignees

@rymnc rymnc

Labels
None yet
Projects
Waku
Status: Done
Milestone
No milestone
2 participants
@rymnc @0x-r4bbit