Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filterv2 support #71

Closed
5 of 6 tasks
richard-ramos opened this issue Sep 27, 2023 · 3 comments
Closed
5 of 6 tasks

feat: filterv2 support #71

richard-ramos opened this issue Sep 27, 2023 · 3 comments
Assignees
@richard-ramos
Labels
E:2.1: Production testing of existing protocols See https://github.com/waku-org/pm/issues/49 for details enhancement New feature or request

Comments

@richard-ramos
Copy link
Member

richard-ramos commented Sep 27, 2023 •
edited

  • Rename and deprecate current filter functions to LegacyFilter
  • filterV2 subscribe
  • filterV2 unsubscribe
  • filterV2 ping
  • filterV2 unsubscribe_all
  • tests
@richard-ramos richard-ramos self-assigned this Sep 27, 2023
@richard-ramos richard-ramos added the E:RLN non-native SDKs See https://github.com/waku-org/pm/issues/88 for details label Oct 1, 2023
@richard-ramos
Copy link
Member Author

Weekly Update

  • achieved: added support for unsubscribe, ping and unsubscribe_all filterv2 functions of go-waku c-bindings
  • next: add support to subscribe

@fryorcraken fryorcraken added enhancement New feature or request E:2.1: Production testing of existing protocols See https://github.com/waku-org/pm/issues/49 for details and removed E:RLN non-native SDKs See https://github.com/waku-org/pm/issues/88 for details labels Oct 3, 2023
@richard-ramos
Copy link
Member Author

Weekly Update

  • achieved: added support to waku_filter_subscribe
  • next: write unit tests for filterv2 and publish new version

@richard-ramos
Copy link
Member Author

Weekly Update

  • achieved: fix issues found during testing
  • next: publish new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-ramos richard-ramos

Labels
E:2.1: Production testing of existing protocols See https://github.com/waku-org/pm/issues/49 for details enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richard-ramos @fryorcraken