Azure SAS Token Must be Prefixed with ?

[Silvenga]

Database name

PostgreSQL

Issue description

Describe your problem

Azure SAS tokens must be prefixed with ?, or the token get's merged with the path resulting in a 404 error. With ? prefixed, the token is correctly merged with the query string.

(the go library handling Azure normally REDACTS the signature from logs, but only when prefixed with ?)

Please provide steps to reproduce

> az storage container generate-sas \
> --account-name <blah> \
> --name <blah> \
> --auth-mode key \
> --permissions acdlrw \
> --https-only \
> --expiry $EXPIRY
se=2031-07-06T09%3A54%3A00Z&sp=racwdl&spr=https&sv=2018-11-09&sr=c&sig=<blah>

Giving this string directly to wal-g e.g.

export AZURE_STORAGE_SAS_TOKEN=se=2031-07-06T09%3A54%3A00Z&sp=racwdl&spr=https&sv=2018-11-09&sr=c&sig=<blah>

Results in 404 errors (with the string concatenated with the requires URL path).

---

IMO, this shouldn't be required (or it should be documented?). It feels rather odd to require it.

This could be a bug in the go library, not 100% sure. The go library is definitely impacted by this bug Azure/azure-storage-azcopy#122 (comment) - so updating that dependency might be a good idea anyway.

The issue #1008 appears unrelated.

[serprex]

This was an oversight in #642 by yours truly. It'd make sense to prepend ? when it's missing from the string

[x4m]

Hi! Improvements to Azure storage would be very welcome!

[Silvenga]

Thanks @serprex!