Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird generic types in DefaultFixedPointSystem #67

Open
msridhar opened this issue May 19, 2015 · 0 comments
Open

Weird generic types in DefaultFixedPointSystem #67

msridhar opened this issue May 19, 2015 · 0 comments

Comments

@msridhar
Copy link
Member

When fixing another bug, I noticed some strange generic type instantiations in DefaultFixedPointSystem. In particular, all the addStatement methods instantiate generic types with ? or no type parameter instead of using T, e.g.:

https://github.com/wala/WALA/blob/master/com.ibm.wala.util/src/com/ibm/wala/fixedpoint/impl/DefaultFixedPointSystem.java#L107
https://github.com/wala/WALA/blob/master/com.ibm.wala.util/src/com/ibm/wala/fixedpoint/impl/DefaultFixedPointSystem.java#L122

I was going to go through and fix these to refer to T, but then I wondered if there is some good reason for the code to be this way. @juliandolby @sjfink any idea what is going on here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant