Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Do List: List structure #1

Merged
merged 3 commits into from May 31, 2022
Merged

To Do List: List structure #1

merged 3 commits into from May 31, 2022

Conversation

wale-prog
Copy link
Owner

In this pull request, I have done the following:

  • initiated this project with webpack, and created the HTML file dynamically in the dist folder using the HTML Webpack plugin.
  • installed CSS loaders to enable the compilation of the CSS file.
  • create an array of objects to hold to-do data
  • description in the to-do data along with a boolean expression that shows if the task has been completed is saved in an array of objects and then dynamically loaded to the page.

Copy link

@KayLemba KayLemba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project Approved 🚀

Hi @wale-prog 🥇,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • No linter errors
  • Your files are well structured

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@wale-prog wale-prog merged commit 7d8a384 into main May 31, 2022
@wale-prog wale-prog deleted the list-structure branch June 1, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants