Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enums for error IDs and hotkey types #12

Closed
walfie opened this issue Nov 12, 2021 · 1 comment
Closed

Use enums for error IDs and hotkey types #12

walfie opened this issue Nov 12, 2021 · 1 comment

Comments

@walfie
Copy link
Owner

walfie commented Nov 12, 2021 •
edited

Error IDs: https://github.com/DenchiSoft/VTubeStudio/blob/master/Files/ErrorID.cs
Hotkey types: https://github.com/DenchiSoft/VTubeStudio/blob/master/Files/HotkeyAction.cs

There should be a variant in the enum that accepts a raw value (i32 or string) to be forward compatible, when new variants are added. Equality checks should also consider forward compatibility.

Message types could also be enums.
@walfie
Copy link
Owner Author

walfie commented Nov 14, 2021

Resolved by #20, #21, #22, #23

@walfie walfie closed this as completed Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@walfie