Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cljs tests #2

Closed
myguidingstar opened this issue Feb 21, 2018 · 3 comments · Fixed by #119
Closed

Add cljs tests #2

myguidingstar opened this issue Feb 21, 2018 · 3 comments · Fixed by #119
Labels
good first issue Good for newcomers

Comments

@myguidingstar
Copy link
Contributor

The SQL builder is written in plain Clojure data structure hence it should work in both Clojure and Clojurescript
@myguidingstar
Copy link
Contributor Author

add cljs unit tests, too

@myguidingstar
Copy link
Contributor Author

moved to cljc but cljs unit tests are stil missing

@myguidingstar myguidingstar changed the title Move all to .cljc Add cljs tests Feb 24, 2018
@myguidingstar myguidingstar added the good first issue Good for newcomers label Feb 26, 2018
@myguidingstar
Copy link
Contributor Author

though cljs unit tests work smoothly via cljc, it's impractical to run walkable in nodejs env without async interface. This can only be done till pathom's async api is ready

@myguidingstar myguidingstar reopened this Apr 8, 2018
@myguidingstar myguidingstar mentioned this issue Nov 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cljs test walkable-server/walkable
1 participant
@myguidingstar