Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TcpConnection中close的一个错误 #39

Closed
agui2200 opened this issue Aug 29, 2015 · 3 comments
Closed

TcpConnection中close的一个错误 #39

agui2200 opened this issue Aug 29, 2015 · 3 comments
Labels

Comments

@agui2200
Copy link

TcpConnection 中close方法中$this->send 参数错误,导致错误的数据包解析失败,gateway无限epoll_wait假死

@walkor
Copy link
Owner

walkor commented Aug 29, 2015

close方法中$this->send 参数错误

没看出参数哪里错了

@agui2200
Copy link
Author

.....就$this->send,在close方法里面,send的时候,传的是你自己写的msg字符串,然后因为定义的方法,默认是要去封包的,封包的时候就会失败了,还有个问题,set_error_handler,这个东西,我觉得workerman自己应该定义一个

@walkor
Copy link
Owner

walkor commented Aug 30, 2015

发个pullrequest吧,看不懂你在说什么。 定义方法?封包失败?因为定义的方法导致封包失败?

set_error_handler 框架自身用不到这个,没有必要定义。并且定义了可能会影响业务,因为业务很可能会定义自己的set_error_handler 。如果业务需要它可以完全自己定义。

@walkor walkor closed this as completed Sep 5, 2015
@walkor walkor added the invalid label Jan 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants