Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags when storing #157

Open
luckydonald opened this issue Nov 25, 2018 · 5 comments
Open

Add tags when storing #157

luckydonald opened this issue Nov 25, 2018 · 5 comments

Comments

@luckydonald
Copy link

luckydonald commented Nov 25, 2018

Q A
Device? iPhone SE & 6
Device Os version 11.3
App Version *
Wallabag server version 2.0+

Steps to reproduce/test case

Share an website via share extension.

Improvement

Instead of showing a small (useless) wallabag icon, which can't even be aborted,
it should feature a cancel button, and later a field to add tags.
Note: this is not about displaying tags in any list or something, like the broader #26 talks about.

So the flow could be like the follwing.

Sub steps b), c) etc. are optionally, and could be added later, incrementally, to enhance functionality in small steps and be easier to implement.

  1. In a browser share any page to Wallabag via share menu
  2. send page to the server (this already exists)
    b) Have a cancel button
  3. load tags generated by tagging rules on the server side (or maybe already existing article?)
  4. Show tag field
    b) can we automatically pop open the keyboard?
    c) Maybe auto completion for the tags can be provided?
  5. Have a submit button
    b) Have a abort (don't store tag updates) button
    c) have a delete article button image
    d) have a mark-as-read button image
    e) have a edit title (and url?) button image
  6. on submit, store the tags the user added to the server.
  7. done, back to browser.

Example screenshots

Here are some screenshot from the browser plugin:

Initial storing process:

screen shot 2018-11-25 at 22 59 22


After storing and loading tags from the server:

screen shot 2018-11-25 at 22 59 12


Tag auto completion:

screen shot 2018-11-25 at 23 10 14

@bourvill
Copy link
Member

You posted on wrong repository. this repository is for ios app.

Thank's

@froschdesign
Copy link

@bourvill
Sorry, but the issue report is correct here. The screenshots shows only the handling from the browser plugin and the same handling should be available in the iOS app.

@bourvill bourvill reopened this Nov 26, 2018
@luckydonald
Copy link
Author

@froschdesign Yes, thanks.

@thibaultamartin
Copy link

The Wallabag app is being rewritten. Current major won't get a fix for this, and it's not yet planned for the 5.0.x versions. We're focusing on polishing the existing features before diving into new ones.

If you want to join the beta, you can follow the Testflight link. Keep in mind the beta still is unstable, and any update can completely break the app (and potentially do some nasty things on your Wallabag instance).

I leave this issue open to keep track of it, but it may never actually implemented if nobody from the development side has interest in. Everyone is a volunteer here :)

@schaafjs
Copy link

schaafjs commented Apr 3, 2022

Any updates on this? This feature is a must have for me and the only thing that's currently holding me back from switching to Wallabag from Pocket.

I do not own a Mac and can therefore not aid in the development. If you need anything tested, feel free to let me know!

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants