Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronisation needs to be triggered manually #232

Open
thibaultamartin opened this issue Dec 11, 2019 · 4 comments
Open

Synchronisation needs to be triggered manually #232

thibaultamartin opened this issue Dec 11, 2019 · 4 comments
Labels

Comments

@thibaultamartin
Copy link

Q A
Device? iPhone
Device Os version 13.2.3
App Version 5.0.0 Build 230
Wallabag server version 2.3.8

Steps to reproduce/test case

Add articles to Wallabag. Synchronise it with the app. Open an article an mark it as read.
Kill the app. When launching the app again, the article is not marked as read.

Improvement

Trigger the synchronisation as soon as the "read" button is pressed.

@bourvill bourvill added the Bug label Dec 11, 2019
@thibaultamartin
Copy link
Author

thibaultamartin commented Jan 2, 2020

Problem still occurs with build 232. The full synchronisation should be triggered when:

  • the instance and account configuration is finished
  • the app starts

Maybe a full synchronisation should not be triggered in following cases, as wallabag API supports single entry for these cases:

  • an article is marked as read
  • an article is marked as unread
  • an article is favourited
  • an article is unfavourited
  • a tag is added
  • a tag is removed
  • an article is added by manually entering the address
  • an article is added from clipboard
  • an article is added from "Share to Wallabag"
  • an article is deleted (by clicking on the trash icon when reading an article)

@thibaultamartin
Copy link
Author

Linked to issue #185

@thibaultamartin
Copy link
Author

Edited second post to add

an article is added from "Share to Wallabag"

This is linked to #231

I think this bug should be chased and smashed before releasing the 5.0.0 version to the App Store :)

@bourvill
Copy link
Member

After proofreading this proposal the background is very good.

In the state it does not work less well than before. But no longer trigger automatic refresh at launch. (A good point in relation to # 185)

The manual synchronization action is not practical I recognize it.

Regarding each task such as favorites, reading ... they do not trigger full synchronization, but only pushes action on the server

The solid bases of the migration to CoreData will make it possible to launch more events depending on the operations and reduce full synchronization. There is still a lot of work on this point.

I think that will not be able to launch the application with this synchronization system, but it should be the focus of a next release.

@thibaultamartin thibaultamartin changed the title [Beta] Synchronisation needs to be triggered manually Synchronisation needs to be triggered manually Feb 20, 2020
@thibaultamartin thibaultamartin modified the milestones: 5.0.0, 5.1.0 Feb 20, 2020
@bourvill bourvill removed this from the 5.1.0 milestone Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants