-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving a PDF document #116
Comments
Hello @remil19! I don't know if this feature has to be implemented in wallabag (our new name). |
In fact, with a PDF file, no informations about the title are transmitted by HTTP. You can test it with any pdf document online with http://web-sniffer.net/. Of course, we can also use an external library to read metadata informations. |
I just added the "Plugin" label to this issue. |
Sorry to answer so late but the first line of a PDF usually begin with %PDF so i guess we could look for this string when a entry is created (and i think it could be usefull to be implemented directly in Wallabag : many long and interesting documents are published in PDF and it may not require a lot of modification : maybe just a boolean in the database or a type attribute and you also could just use this viewer: https://github.com/mozilla/pdf.js). |
Yes, detection with parsing first bytes of files isn't really easy to made, compared to http headers detection. Although, I don't know if all servers serve pdf properly. |
Going for v2.x. |
Assigned to Tender discussion #4. |
For now, instead of storing the pdf itself, we provide a text version of it: j0k3r/graby#16 |
Done by @j0k3r in graby 👍 |
I tried saving PDF-url with wallabag v2.0.1, but I get " wallabag can't retrieve contents for this article. Please report this issue to us. " error. Would be great if wallabag downloaded the original PDF and stored it locally for future reading. |
Can you open a new issue for that please? |
Hey, I have the same trouble as you. For me, I still cannot save PDF from a PDF url onto Wallabag. If it saves, sometimes the text is just unreadable. How is it now for you? |
J'ai essayé d'ajouter un pdf qui s'était ouvert dans mon navigateur via pdf.js à poche, mais celui-ci l'enregistre comme du texte brut et sans titre. Ce serait bien qu'il enregistre un titre et qu'il l'ouvre dans un onglet quand on clique dessus.
The text was updated successfully, but these errors were encountered: