Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email sharing not functional with gmail #1173

Closed
Linuxine opened this issue Apr 1, 2015 · 4 comments
Closed

Email sharing not functional with gmail #1173

Linuxine opened this issue Apr 1, 2015 · 4 comments
Assignees
Labels

Comments

@Linuxine
Copy link

Linuxine commented Apr 1, 2015

Hi,

after updating my wallabag to the 1.9, maybe I have misconfigured something, but the "share by email" feature seems broken : when I click on the button, I get a new email, with the title of the article as a subject, but the content is strange (using gmail to handle the mailto links) : there is not link to the article, only the title of the article and/or his first lines.

For example, I have added this article : http://campus.lemonde.fr/campus/article/2015/04/01/le-canada-durcit-l-accueil-des-stagiaires-etrangers_4607268_4401467.html

When I click on the "email" button, the only content of the email is :
" Mauvaise nouvelle pour les jeunes Français à la recherche d'un stage à l'étranger : la nouvelle réglementation du gouvernement fédéral concernant les demandes d'EIC (Expérience internationale Canada) aura «"
which is the beginning of the article, truncated.

I have not tried yet with another email provider or client.

@tcitworld tcitworld added the Bug label Jul 28, 2015
@phofm
Copy link

phofm commented Aug 14, 2015

I believe the problem is independent of the email client.

I have the same problem with this article.

Looking into the generated E-Mail-Link the problem appears to be the ampersand (&, encoded with HTML entity & but turned into an actual & in the email client). The ampersand in such an email link denotes the beginning of a new field (cf. &body=):

<a title="Email" class="tool email icon icon-mail" 
href="mailto:?subject=It turns […] of a partner
&amp;body=[…] parenthood is supposed to be among the&amp;<!-- This is the culprit -->nbsp;most 
joyous. [rest cut]"><span>Email</span></a>

I don’t have the time to look into the Wallabag code at the moment, but I could imagine something along the lines of

$article_snippet = urlencode($article_snippet);
/* or potentially use rawurlencode for compliance with RFC 3986 */

might solve the problem.

If I find some free time I will look into this.

@nicosomb
Copy link
Member

Is that the same bug than #1273?

@phofm
Copy link

phofm commented Aug 14, 2015

I can send the artice referenced in #1273 with the email link and get a new message with the title as subject and snippet and link in the body. So I would say no, not the same bug.

However, I did notice that some spaces get dropped that are there on the original page:
For example:

[…] Windows 10.Vous […]
[…] bougé depuisWindows 7 […]
[…] gratuites etperformantes […]

But I can’t see whether and how that is related to this bug.

@tcitworld tcitworld self-assigned this Aug 24, 2015
@nicosomb
Copy link
Member

Fixed in v2 cause we only send article's title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants