Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup in composer.json #1356

Closed
nicosomb opened this issue Aug 17, 2015 · 2 comments
Closed

Cleanup in composer.json #1356

nicosomb opened this issue Aug 17, 2015 · 2 comments
Assignees
Milestone

Comments

@nicosomb
Copy link
Member

Today, we have lot of dependancies in composer.json and github requests a token. I believe (but not sure) it's because our libraries are not tagged.

@j0k3r @FabienM any idea?

@nicosomb nicosomb added this to the 2.0.0-alpha.0 milestone Aug 17, 2015
@j0k3r
Copy link
Member

j0k3r commented Aug 18, 2015

I guess this is because we use these deps as vcs so Composer can't get an archive from that vcs and need to clone the project.

What should be done:

  • tag each libraries (which seems to be already done)
  • use tag in composer.json

If it still doesn't work we need to declare them on packagist.

Also, I think we can cleanup few things, like kriss_php5, I don't think we need this one.

@nicosomb
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants