Wrong Content-Disposition header when download epub (rfc1806)

[alkahan]

When download an epub file, the content-disposition header value is wrong:

Result:
Content-Disposition: attached; filename="title.epub"

Should be:
Content-Disposition: attachment; filename="title.epub"

see: http://www.ietf.org/rfc/rfc1806.txt

Impact:
The filename is not set properly on some devices like my Sony Reader, and use default filename "filename.bin". The device cannot open the file with that name.

[j0k3r]

I guess you are talking about the v1 ?
Feel free to provide a PR about that, it's an easy bug to fix.

➡️

wallabag/inc/3rdparty/libraries/PHPePub/Zip.php

Line 572 in 7d6bd56

$cd .= "attached";

[alkahan]

Yes in v1 :1.9.1.

You are right, I will provide a PR today.

[j0k3r]

@alkahan awesome ! Don't forget to target the dev branch instead of the master.

[tcitworld]

The PR can also be submitted to the PHPePub project.

[alkahan]

@tcitworld I have made a PR for PHPePub 3.30 branch. Current master and 4.0.0 rely on PHPZip and provide the right header value.

[tcitworld]

Nice. wallabag v2 relies on PHPePub 4.0 so it will be fine.

[nicosomb]

Can we close this issue?

[j0k3r]

We don't use sendBook in the v2, we built the response ourself.