Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot import very long article (v2) #1724

Closed
nkoehring opened this issue Feb 25, 2016 · 4 comments
Closed

cannot import very long article (v2) #1724

nkoehring opened this issue Feb 25, 2016 · 4 comments
Assignees
Labels

Comments

@nkoehring
Copy link

Issue details

I try to import http://ledger-cli.org/3.0/doc/ledger3.html and it fails with a 500 (log says: readability.php exceeded the maximum execution time of 30s).

Is there any way to speed this up?

Environment

Wallabag v2.0.0-alpha.2
on Arch Linux ARM
with sqlite database

Steps to reproduce/test case

try to import http://ledger-cli.org/3.0/doc/ledger3.html

@j0k3r
Copy link
Member

j0k3r commented Feb 25, 2016

I agree that article is very long. I guess your server isn't that fast, right?
I tried on two different machine and, apart the fact that it took longer than usual, the content was well imported (http://v2.wallabag.org/view/4870).

I'll see if I can optimized few things on Readability side but I can't guarantee I'll find sth.
In the mean time, can you increase PHP max_execution_time on your server?
Also, could you share your server configuration (ram, cpu speed, etc..)

@tcitworld
Copy link
Member

Is there a way we could timeout the graby query to Readability so that the exception would be caught to avoid a 500 error ?

@nicosomb nicosomb added this to the 2.0.0 milestone Feb 25, 2016
@nkoehring
Copy link
Author

It is not a big server. It's a dedicated ARMv7 with 4 cores clocked at 1.3GHz, sporting 2GB of RAM.

Is it maybe possible to separate the import process from the rendering process and both from the main thread? These long running things should run in the background.

@tcitworld
Copy link
Member

These long running things should run in the background.

Yup, there's #1581 (comment) to implement this.

@nicosomb nicosomb modified the milestones: 2.0.0, 2.0.1 Apr 3, 2016
@nicosomb nicosomb added the Bug label Apr 5, 2016
@nicosomb nicosomb modified the milestones: 2.1.0, 2.0.1 Apr 5, 2016
@nicosomb nicosomb modified the milestone: 2.1.0 Apr 12, 2016
@j0k3r j0k3r closed this as completed Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants