Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only small portion of the website gets saved #1744

Closed
hubertbanas opened this issue Mar 1, 2016 · 4 comments · Fixed by fivefilters/ftr-site-config#134
Closed

Only small portion of the website gets saved #1744

hubertbanas opened this issue Mar 1, 2016 · 4 comments · Fixed by fivefilters/ftr-site-config#134
Labels
Site Config
Milestone
2.0.0

Comments

@hubertbanas
Copy link

Only the last part of the article gets parsed

Source location:
http://www.notebookcheck.net/Lenovo-ThinkPad-X1-Carbon-Ultrabook-Review.138033.0.html

Wallabag v2
http://v2.wallabag.org/view/52
@j0k3r j0k3r mentioned this issue Mar 1, 2016
Merged
@j0k3r
Copy link
Member

j0k3r commented Mar 1, 2016

Oh my god the html structure of this website is so crapy ! I can't believe it ...

Anyway, even if the article is really long I successfully extracted most of the content. There is only the first italic paragraph that get wiped out. But it's still better than only the last paragraph

@j0k3r
Copy link
Member

j0k3r commented Mar 1, 2016

I'll be fixed in the next release.
Thanks !

@j0k3r j0k3r closed this as completed Mar 1, 2016
@j0k3r j0k3r added this to the 2.0.0 milestone Mar 1, 2016
@hubertbanas
Copy link
Author

This is still not fixed in Version: 2.0.0-beta.2

See here:
http://v2.wallabag.org/view/543

@j0k3r
Copy link
Member

j0k3r commented Mar 31, 2016

Yeah sorry it'll be fixed in the 2.0.0 (for sure!).
The beta2 was release before graby-site-config 1.0.15 which integrate siteconfig for notebookcheck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Site Config
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Create notebookcheck.net.txt j0k3r/graby-site-config
3 participants
@j0k3r @nicosomb @hubertbanas