-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bookmarklet import does not work - page closes too fast #1960
Comments
could be related to #238 in some way. |
I'm not sure what the expected behavior should be : tab staying opened a few seconds ? Things that we can do are quite limited with the bookmarklet, I'm not even convinced that we should support it in the future. |
If it stays open, the client got enough time to establish a connection and do the request. I'd suppose that the tab staying open showing the article fetched sounds like a proper solution as you are instantly able to review the spidered page. |
I'll ask for other people's opinion, and make the change if needed. |
Can reproduce on Chrome 50. |
Reproduced on Firefox 45.0.2 (Linux) and Firefox 38.0.x (Windows). |
I've been running more tests and it looks like the "wllbg.close;" in the bookmarklet is the problem. If I remove that I have no problem. The web server running Wallabag is quite slow. This would be a much-appreciated fix, or replace with something else. |
PeterTGarner, thank you!! That fixed my issueses as well. Ive been using wallabag for a good year or two and this is the single most important feature if you ask me! |
i was also having problems with the bookmarklet
i think that if you just adjust the setTimeout value to fit your needs everything should be good to go |
Issue details
Using the bookmarklet 'bag it!' you cannot import articles as it closes too fast
Environment
git clone
Steps to reproduce/test case
wllbg.close();
to keep the window open to maybe get an error messagewllbg.close();
kicks in too fast for actually getting the request through the serverThe text was updated successfully, but these errors were encountered: