Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags not handled in /api/entries #1984

Closed
ghost opened this issue Apr 26, 2016 · 7 comments
Closed

Tags not handled in /api/entries #1984

ghost opened this issue Apr 26, 2016 · 7 comments
Milestone

Comments

@ghost
Copy link

ghost commented Apr 26, 2016

Issue details

The API isn't handling tags as mentioned in the documentation, there's simply no code for it :D

Environment

  • wallabag version (or git revision) that exhibits the issue: 2.0.3
  • How did you install wallabag? Via git clone or by downloading the package? git clone
  • Last wallabag version that did not exhibit the issue (if applicable):
  • php version: 5.5.10
  • OS: CentOS
  • type of hosting (shared or dedicated): shared
  • which storage system you choose at install (SQLite, MySQL/MariaDB or PostgreSQL): SQLite
@ghost ghost added the Bug label Apr 26, 2016
@ghost ghost added this to the 2.0.4 milestone Apr 26, 2016
@ThibaudDauce
Copy link
Contributor

It could be really cool to have that for the Firefox extension (add tag after saving a page)

@nicosomb
Copy link
Member

nicosomb commented May 2, 2016

In fact, I change the milestone, because we decided to implement tags features for wallabag 2.1.

@nicosomb nicosomb added Improvement and removed Bug labels May 2, 2016
@nicosomb nicosomb modified the milestones: 2.1.0, 2.0.4 May 2, 2016
@Strubbl
Copy link
Contributor

Strubbl commented May 3, 2016

Just linking the issues wallabag/android-app#230 and wallabag/android-app#231 which need this feature first.

@tcitworld
Copy link
Member

What is the issue here ?
If I access api/entries.json, api/entries/1.json, or api/entries/1/tags.json, I always get the tags (on master branch as on 2.1).

@ghost
Copy link
Author

ghost commented Jun 25, 2016

Yep, I can delete or add tags to an item. However if I want to recieve items with one or more specific tags (GET /api/entries.json with tags parameter) the resulted items doesn't contain the tags or just one of them.
The second issue I found is that I can't delete a tag from all items (DELETE /api/tags/1337.json).

@tcitworld
Copy link
Member

I fixed the first issue at #2174.

I can't reproduce the second issue : I attributed a tag to two articles, and deleted it successfully without issues.

@ghost
Copy link
Author

ghost commented Jun 25, 2016

Ah, had a look at my unit tests again. The API was working, but my test was depending on the first issue you already fixed and therefore it was failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants