Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallabag can't retrieve contents for this article: o6asan.com #2099

Closed
zertrin opened this issue May 19, 2016 · 6 comments
Closed

wallabag can't retrieve contents for this article: o6asan.com #2099

zertrin opened this issue May 19, 2016 · 6 comments

Comments

@zertrin
Copy link
Contributor

zertrin commented May 19, 2016

Issue details

wallabag can't retrieve contents for this article:

https://o6asan.com/blog-e/2016/03/14/how-to-install-a-lets-encrypt-certificate-supports-sans-to-apache-on-windows/

Environment

  • wallabag version (or git revision) that exhibits the issue: 2.0.4
  • How did you install wallabag? Via git clone or by downloading the package? git clone
  • Last wallabag version that did not exhibit the issue (if applicable): not tested with previous versions
  • php version: PHP 5.6.20-0+deb8u1 (built: Apr 27 2016 11:26:05)
  • OS: Debian Jessie
  • type of hosting (shared or dedicated): dedicated
  • which storage system you choose at install (SQLite, MySQL/MariaDB or PostgreSQL): SQLite
@Strubbl
Copy link
Contributor

Strubbl commented Jun 17, 2016

works fine on: http://ftr.fivefilters.org/makefulltextfeed.php?url=https%3A%2F%2Fo6asan.com%2Fblog-e%2F2016%2F03%2F14%2Fhow-to-install-a-lets-encrypt-certificate-supports-sans-to-apache-on-windows%2F&max=3

And also in wallabag.

@zertrin can you please test with the latest wallabag release again and report if that fixes the issue?

@zertrin
Copy link
Contributor Author

zertrin commented Jun 20, 2016

Just upgraded to 2.0.5 and it is still not working:

No title found
wallabag can't retrieve contents for this article. Please report this issue to us.

@zertrin
Copy link
Contributor Author

zertrin commented Jul 1, 2016

In case it helps, I've used http://siteconfig.fivefilters.org to generate a FiveFilters siteconfig:

# Generated by FiveFilters.org's web-based selection tool
# Place this file inside your site_config/custom/ folder
# Source: http://siteconfig.fivefilters.org/grab.php?url=https%3A%2F%2Fo6asan.com%2Fblog-e%2F2016%2F03%2F14%2Fhow-to-install-a-lets-encrypt-certificate-supports-sans-to-apache-on-windows%2F

body: //div[contains(concat(' ',normalize-space(@class),' '),' entry-content ')]
test_url: https://o6asan.com/blog-e/2016/03/14/how-to-install-a-lets-encrypt-certificate-supports-sans-to-apache-on-windows/

but entry-content seems to be probably a common guess for unknown websites, so not sure if it helps really.

@j0k3r
Copy link
Member

j0k3r commented Jul 19, 2016

@zertrin siteconfig are per host based. If you provide the entry-content for o6asan.com host it won't be used for other host.

Could you then submit a PR to https://github.com/fivefilters/ftr-site-config with your fix?

@zertrin
Copy link
Contributor Author

zertrin commented Jul 19, 2016

Done: fivefilters/ftr-site-config#185

siteconfig are per host based. If you provide the entry-content for o6asan.com host it won't be used for other host.

I get that, but I assume that if a site is not listed on the ftr-site-config list, there is a kind of "default parser" to fallback. And I was wondering why entry-content is not a pretty obvious candidate to get the correct content... If we need to create a config site for every domain name in the world, I guess something is wrong in the design...

@j0k3r
Copy link
Member

j0k3r commented Jul 19, 2016

As far as I know, a global siteconfig is used for every website

➡️ https://github.com/fivefilters/ftr-site-config/blob/master/global.txt

(and I close this issue this the PR is open on fivefilters/ftr-site-config)

@j0k3r j0k3r closed this as completed Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants