Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS: Different "Access-Control-Allow-Origin" header behaviour #2215

Closed
Rurik19 opened this issue Aug 11, 2016 · 6 comments
Closed

CORS: Different "Access-Control-Allow-Origin" header behaviour #2215

Rurik19 opened this issue Aug 11, 2016 · 6 comments

Comments

@Rurik19
Copy link
Contributor

Rurik19 commented Aug 11, 2016

Issue details

Wallabag adds 'Access-Control-Allow-Origin' in API section POST response, but in OAuth part it doesn't, so I have to add it myself in nginx server config for OAuth part separately.

Is it possible to add this header for OAuth part?

Environment

  • wallabag version 2.0.6
  • How did you install wallabag? Via git clone
@j0k3r
Copy link
Member

j0k3r commented Aug 11, 2016

I think we just need to duplicate the api rule here and change the '^/api/': to '^/oauth/': so it'll be enabled CORS on the oAuth endpoint /oauth/v2/token.

@j0k3r j0k3r added the Easy bug label Aug 11, 2016
@Rurik19
Copy link
Contributor Author

Rurik19 commented Aug 12, 2016

I did so, but it seems that doesn't work. I restarted php5-fpm and nginx, is that enought for reread config?

@j0k3r
Copy link
Member

j0k3r commented Aug 12, 2016 via email

@Rurik19
Copy link
Contributor Author

Rurik19 commented Aug 12, 2016

Thanks, cleaning cache make thing works.

@j0k3r
Copy link
Member

j0k3r commented Aug 12, 2016 via email

@nicosomb
Copy link
Member

Fixed by #2216.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants