Orphaned tags.

[Rurik19]

Issue details

After deleting article with unique tag, this tag remains in the tags table, accessible from nowhere.
API and UI the have the same behaviour

[j0k3r]

Are you sure about from the web interface?
Because we should remove the tag if no entries are associated: #1663 (see 567421a#diff-ebd626b4b8a67462013f01007d7a4637R70)

[Rurik19]

Just checked web interface:

• add new tag to the article
• delete article (by clicking on trash icon on article card)
• i still see the tag in database with phpmyadmin

[j0k3r]

Did you try on the master directly? Because, as the milestone says, it'll be released with the 2.1.2 version which is not yet available.

[Rurik19]

Yes, that is on 2.1.1 from master.

[j0k3r]

Master is the upcoming 2.1.2.
Are you sure that tag isn't associated to an other entry?

[Rurik19]

Yes, that was "Just_for_test" tag :)

[j0k3r]

Well, it works for me, so..
@nicosomb @tcitworld could you please try on your side?

[nicosomb]

I have the problem with SQLite too.

[j0k3r]

@Rurik19 could you please tell me step by step all actions to reproduce the bug? I've tried on PostgreSQL, MySQL & SQLite and it works every time.

[Rurik19]

@j0k3r
0) PHP Version 5.6.24-0+deb8u1
MySQL ver: 5.5.52-0+deb7u1

1. git pull origin master
   ➜ wallabag2 git:(4533342) ✗
2. SYMFONY_ENV=prod composer install -o --prefer-dist
3. add tag to article
4. delete article
   
5. look at phpmyadmin
   

[nicosomb]

In fact, what is the problem with this behavior?
The tag is still in database because maybe it's used by an other user (a tag has no relation with a user).
It stays in database but if we affect this tag to a new article, this tag will be used.

[Kdecherf]

Is this issue still relevant?