Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max-width #301

Closed
tcitworld opened this issue Nov 6, 2013 · 10 comments
Closed

Increase max-width #301

tcitworld opened this issue Nov 6, 2013 · 10 comments
Labels
Milestone

Comments

@tcitworld
Copy link
Member

Currently max-width is set to 33em. It may be fine on mobile browsers, but should be increased to something like 60em for a fine display on desktop.

@jn0
Copy link
Contributor

jn0 commented Nov 13, 2013

I think, 800px width is the max of readable page in desktop environment.

@tcitworld
Copy link
Member Author

Well, I find it the minimum size for acceptable view, given my screen resolution. Of course, for old screens it should be around this. So we should give it in em and not in px.

@jn0
Copy link
Contributor

jn0 commented Nov 13, 2013

If you give the screen size in em, then you relay upon (1) resolution and (2) font (which one?) size...
Hence, if one uses large fonts (accessibility!), then he'll get a huge page.
Another one with smaller fonts (in a hope to fit more text), will be given with narrow column instead.

Am I wrong?

Then, it'd be reasonable to use absolute units (mm)...

@nicosomb
Copy link
Member

I'm not an a11y expert but I think em is better, isn't it?

@jn0
Copy link
Contributor

jn0 commented Nov 14, 2013

Again, em-size depends on font chosen.
While the view port is somehow absolute.

@tcitworld
Copy link
Member Author

Well, I think you can have a width in em and a max-width in px.

@nicosomb
Copy link
Member

Not sure it's the job of poche core. The template has to do it.

@jn0
Copy link
Contributor

jn0 commented Nov 21, 2013

CSS via PHP considered an overkill, definitely.
Presentation part (CSS) should not be intermixed with any "business" logic.
I see nothing wrong or bad in creating an own skin by cloning an existing one and editing (that max-width, for instance).

@tcitworld
Copy link
Member Author

Not sure it's the job of poche core. The template has to do it.

I can't see why you are saying this. Nobody talked about this, did we ? :)

@nicosomb
Copy link
Member

Clean up mode: can I close this issue? We have Baggy theme now, maybe this one is better than the default one.

@nicosomb nicosomb removed the Question label Jul 30, 2014
@nicosomb nicosomb changed the title [v2] Increase max-width Increase max-width Jul 31, 2014
@nicosomb nicosomb modified the milestones: 2.0, 2.0.0-alpha Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants