Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make run is broken #3391

Closed
notFloran opened this issue Oct 25, 2017 · 5 comments
Closed

make run is broken #3391

notFloran opened this issue Oct 25, 2017 · 5 comments
Milestone

Comments

@notFloran
Copy link
Contributor

Issue details

make run does not work since the upgrade to Symfony 3.3 (#3376 and #3381) : the makefile execute the command server:run with the prod env by default but the WebServerBundle is only active in dev env.

I see several solutions:

  • enable WebServerBundle for all env
  • throw an error in makefile for run if the env <> dev

Environment

  • wallabag version (or git revision) that exhibits the issue: master (1953a872932a63792293b4aec087880265ba89f7)
  • How did you install wallabag? git clone
  • Last wallabag version that did not exhibit the issue (if applicable): -
  • php version: 7.1
  • OS: macOs
  • type of hosting (shared or dedicated): dedicated
  • which storage system you choose at install (SQLite, MySQL/MariaDB or PostgreSQL): SQLite

Steps to reproduce/test case

Execute make run:

capture d ecran 2017-10-25 a 08 03 55

@tcitworld
Copy link
Member

Well make run shouldn't be used for production, so I don't see this as an issue. :/

@notFloran
Copy link
Contributor Author

shouldn't be used for production, so I don't see this as an issue. :/

@tcitworld I'm ok with that but the README and the doc indicate this:

cd wallabag && make install
make run

And by default the prod env is used by the makefile.

@tcitworld tcitworld reopened this Oct 25, 2017
@tcitworld
Copy link
Member

@wallabag/core Since this is bad behaviour, should we remove from the docs or fix that ?

@Kdecherf
Copy link
Member

Imo we should completely remove the target run and update the documentation accordingly

@nicosomb
Copy link
Member

Fixed with #3481

@j0k3r j0k3r added this to the 2.3.1 milestone Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants