New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace icon fonts with SVG icons #3797
Comments
Should we insert the xml content of svg files inside the html content? |
I think that's what Github did (via a helper) to allow for colorization via CSS. As some of the icons on wallabag are used in grey, black, and white, it would probably be the same thing? I am wondering also if it wouldn't be a good idea to use CSS sprites and use SVG xlink : https://css-tricks.com/svg-sprites-use-better-icon-fonts/ and https://css-tricks.com/svg-symbol-good-choice-icons/ The downsides:
|
I have created a gist with the code for all the icons in More information on svg sprite on Google Material Icon page, and there seems to be ways for older browsers to fallback when they don't support svg. Regarding the color, the icons can inherit the color of the text they are illustrating. |
Wallabag is pretty much unusable if 3rd party fonts are disabled. The interface is fully reliant on material icon font. Github have a good article on why they moved away from icon fonts.
The text was updated successfully, but these errors were encountered: