Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with theme name case #447

Closed
opi opened this issue Feb 12, 2014 · 2 comments
Closed

Bug with theme name case #447

opi opened this issue Feb 12, 2014 · 2 comments
Labels
Milestone

Comments

@opi
Copy link

opi commented Feb 12, 2014

After upgrading to 1.4.0, I was unable to change my theme. I always got the error "that theme does not seem to be installed".
I investigate, and finaly find the bug: the select list on the config page use theme_name as key, with first capital letter.
On the 1.3.0 version the theme list was hardcoded, with theme name in lowercase.

See f4fbfaa

I found my way out by using 'strtolower' on various places in Poche.class.php, and duplicate theme folders with first capital letter.

My opinion is theme identifier (and folders) might be lowercase, while theme name could be capitalized.

@tcitworld tcitworld added the Bug label Feb 12, 2014
@nicosomb
Copy link
Member

Did you try to empty cache folder?

@nicosomb nicosomb added this to the 1.5.0 milestone Feb 12, 2014
@nicosomb
Copy link
Member

Like you said on IRC, bug fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants