FeedWriter.php & ATOM

[kraoc]

Sue la version DEV:

    /**
    * Set the 'description' channel element
    * 
    * @access   public
    * @param    srting  value of 'description' channel tag
    * @return   void
    */
    public function setDescription($desciption)
    {
        $tag = ($this->version == ATOM)? 'subtitle' : 'description'; 
        $this->setChannelElement($tag, $desciption);
    }

La constante ATOM est utilisée sans être définie.

[nicosomb]

ping @tcitworld @jogaulupeau

[nicosomb]

Like @kraoc said here #548 (comment), there is a problem with chrome addon.

[tcitworld]

I've also seen that if PHP displays all errors (Notice level), this causes the generated feeds to become invalid.

[nicosomb]

Is that linked with #583 ?

[tcitworld]

No, though it's the same file.

And as far as I know, the Chrome extension doesn't uses RSS feeds.

[nicosomb]

Fixed here: 2dd5c1e

[kraoc]

Why setting a variable to use it like a constant...

Just do:
$this->setChannelElement('description', $desciption);

[nicosomb]

You're right. Fixed. 9cb9ab5

[kraoc]

Less variable... simplier code... easier to debug & fix :)

Bon et au passage on peut aussi parler notre langue commune... lol

[nicosomb]

You're right... I have to be more attentive ... So tired, but it's not an excuse.

[kraoc]

More spirit pulled in code... Less spirit pulled in debug...

(enfin c'est mon avis)