Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Symfony Flex #5747

Open
yguedidi opened this issue Apr 24, 2022 · 7 comments
Open

Move to Symfony Flex #5747

yguedidi opened this issue Apr 24, 2022 · 7 comments
Labels
Feature topic: technical Issues and pull requests without user impact
Milestone

Comments

@yguedidi
Copy link
Contributor

yguedidi commented Apr 24, 2022

I'm currently working on removing depreciations from Wallabag codebase, so that we can upgrade to newer Symfony.

One big step in Symfony projects in Symfony Flex, that propose new way of managing dependencies, and a newer more standard project structure.
But one of the most impactful change is to not use bundles for application code.

Is migrating to Symfony Flex something you may considere to have a project structure aligned with Symfony recommendation?

If yes, I can work on doing this in multiple steps, the first ones beig to have just one bundle, so migrate in a clean way content of all bundles inside CoreBundle, preserving the separation with namespace.

@Kdecherf
Copy link
Member

Is migrating to Symfony Flex something you may considere to have a project structure aligned with Symfony recommendation?

Yes we would like to move on Symfony Flex.

However I'm wondering if it would be easy to do so without starting a new codebase from scratch; deprecations include, among other things, the rewrite of the user management part as FOSUserBundle is not compatible with Symfony 4+

@Kdecherf
Copy link
Member

If it can help, I made draft PR a few months ago but I abandoned them:

@yguedidi
Copy link
Contributor Author

Yes we would like to move on Symfony Flex.

Great! here a very big picture roadmap I can work on:

  • remove depreciations (in progress)
  • migrate each bundle into CoreBundle (including FOSUserBundle, found this that may help)
  • migrate to Flex new structure (with CoreBundle content being moved directly in src/, mapped as Wallabag namespace

what do you think @Kdecherf ?

@yguedidi
Copy link
Contributor Author

yguedidi commented Apr 24, 2022

from linked PRs:

as I would prefer to focus on a restart of the whole codebase

@Kdecherf I assume this is abandonned? or is it still something you plan to work one?

@j0k3r
Copy link
Member

j0k3r commented Apr 24, 2022

Of course we would like to move to Flex.
But I think we should do it for 2.6.0.
The 2.5.0 is almost there.

@yguedidi
Copy link
Contributor Author

Sure! meanwhile 2.5.0 get realease, I'll work on preparation work, the depreciations

@j0k3r j0k3r added this to the 2.6.0 milestone Apr 24, 2022
@Kdecherf
Copy link
Member

what do you think @Kdecherf ?

Looks good 👍

@j0k3r j0k3r modified the milestones: 2.6.0, 3.0.0 Dec 22, 2022
@j0k3r j0k3r added the topic: technical Issues and pull requests without user impact label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature topic: technical Issues and pull requests without user impact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants