Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to get the content of shaarli posts #639

Closed
AmauryCarrade opened this issue Apr 13, 2014 · 6 comments
Closed

Unable to get the content of shaarli posts #639

AmauryCarrade opened this issue Apr 13, 2014 · 6 comments
Labels
Milestone

Comments

@AmauryCarrade
Copy link
Contributor

When I try to import a link from a Shaarli post, Wallabag answers “nope, [unable to retrieve full-text content]”.

The import does not work will all Shaarli links.

@tcitworld
Copy link
Member

Indeed, but this may be because of the fact Shaarli pages aren't w3c compliant.

Moreover, since shaarli pages aren't on a single domain, it's no use creating specific rules for it. You better may consider proposing a PR for shaarli, if sebsauvages wakes himself. ;)

@AmauryCarrade
Copy link
Contributor Author

Yes, you're right. It's still a bug anyway.

You make exceptions in the code for such websites, so...

13 avril 2014 18:49 "tcitworld" notifications@github.com a écrit:

Indeed, but this may be because of the fact Shaarli pages aren't w3c compliant.

—Reply to this email directly or view it on GitHub.

@tcitworld
Copy link
Member

I've edited my comment above. You're a bit right, I want to see what the others think.

@tcitworld tcitworld added the Bug label Apr 13, 2014
@AmauryCarrade
Copy link
Contributor Author

We can detect Shaarli (there is some specific codes, like :

<link type="text/css" rel="stylesheet" href="inc/shaarli.css?version=<str>" />

).

Send a PR to Shaarli is a good idea; However, the dissemination of such a PR may take a long time (not counting the very long period of acceptance of that said PR).

@tcitworld
Copy link
Member

There shouldn't be a specific rule for shaarli. However, we may be able to modify/extend the parser class to get around the bugs shaarli produces.

@nicosomb nicosomb added this to the 1.8.0 milestone May 2, 2014
@tcitworld tcitworld modified the milestones: 1.9.1, 1.9.0 Feb 10, 2015
@tcitworld tcitworld modified the milestones: 1.9.1, 1.9.2 May 22, 2015
@nicosomb
Copy link
Member

nicosomb commented Feb 4, 2016

I close this issue. We can't add specific rules for problems like that.

@nicosomb nicosomb closed this as completed Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants