Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallabag's coding style #661

Closed
tcitworld opened this issue Apr 23, 2014 · 3 comments
Closed

wallabag's coding style #661

tcitworld opened this issue Apr 23, 2014 · 3 comments
Milestone

Comments

@tcitworld
Copy link
Member

Proposition, based on what I've been told. It's more a reminder for me than a guideline, though.

  • Brackets come after one space after a statement :
somecode;
myFunction() {
    somethingtodo;
}
  • Brackets close at the same indentation level than the statement which opened them (see above)
  • Tabs are made of four spaces

Much more detailed advises can be found on Zend's Documentation.

Send me ideas. :)

@eazrael
Copy link

eazrael commented Apr 23, 2014

Oh, braces placement. I prefer Allman style, where each closing brace is on the same indention level as the opening brace.

But it's your code, it must please your eye. https://en.wikipedia.org/wiki/Indent_style

@tcitworld
Copy link
Member Author

I don't know. I've seen much of the code already like this, so let's vote.

@nicosomb nicosomb added this to the 2.0 milestone May 19, 2014
@nicosomb
Copy link
Member

nicosomb commented Aug 1, 2014

Oh I forgot this issue.
We now have GUIDELINES.md file: https://github.com/wallabag/wallabag/blob/dev/GUIDELINES.md

@nicosomb nicosomb closed this as completed Aug 1, 2014
@nicosomb nicosomb modified the milestones: 2.0, 2.0.0-alpha Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants