Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes lost in article #670

Closed
lightonflux opened this issue Apr 29, 2014 · 7 comments
Closed

Footnotes lost in article #670

lightonflux opened this issue Apr 29, 2014 · 7 comments
Milestone

Comments

@lightonflux
Copy link

I used wallabag with this article:

http://blog.tjll.net/ssh-kung-fu/

There are two footnotes below the article, which wallabag missed.

Luckily the HTML is

<div class="footnotes">

so at least for this site the fix should be easy. But i don't know how other blog software handles footnotes.

@pVesian
Copy link

pVesian commented Apr 30, 2014

The class .footnotes isn't in the W3C specs, so I don't think that adding a
behaviour just for this website is a good idea.

@lightonflux
Copy link
Author

True, but many sites use it this way and there are some plugins for web infrastructure that handle it that way e.g. Wordpress or jQuery Plugins.

@tcitworld
Copy link
Member

It's the wallabag core (e.g. the readability class) which should respect W3C specs. Specific rules for websites should be just the way they take the page the best, regardless of specs.

@tcitworld tcitworld added this to the 1.8.0 milestone Jun 5, 2014
@nicosomb
Copy link
Member

Do we have something to do on this issue?

@nicosomb nicosomb modified the milestones: 1.8.0, 1.9.0 Jul 30, 2014
@mariroz
Copy link
Contributor

mariroz commented Jul 31, 2014

will fix this, but only in 2 weeks.
idea is to create site config file with correct class replacement.

@mariroz mariroz self-assigned this Aug 21, 2014
@tcitworld tcitworld modified the milestones: 1.9.1, 1.9.0 Feb 10, 2015
@tcitworld tcitworld modified the milestones: 1.9.1, 1.9.2 May 22, 2015
@nicosomb
Copy link
Member

This issue affects wallabag v1. This version won't move anymore.

@lightonflux
Copy link
Author

Does this work in 2.0? I don't have a v2 instance for testing at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants