Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPUB-Download for more than one article create a corrupt file #717

Closed
msone opened this issue Jun 3, 2014 · 10 comments
Closed

EPUB-Download for more than one article create a corrupt file #717

msone opened this issue Jun 3, 2014 · 10 comments
Assignees
Labels
Milestone

Comments

@msone
Copy link

msone commented Jun 3, 2014

More than one articles as EPUB create a corrupt EPUB-file. If I rename this to *.zip, my packer says: there are errors in the file.

My configuration
Wallabag 1.7
Shared Hosting
PHP 5.3.28
MySQL-Storage
Error-Message from the server:
PHP Warning: fwrite() expects parameter 1 to be resource, boolean given in /is/htdocs/xxx/wallabag/inc/3rdparty/libraries/PHPePub/Zip.php on line 719

@tcitworld
Copy link
Member

Hi,
Which method did you use to create the epub ? (search/category/tag/all ?)
If the bug occurs with a tag (too), could you give us the links from the concerned articles ? Two articles should be enough, if the bug occurs with them.

@tcitworld
Copy link
Member

Also, please tell me if concerned articles have special/unusual characters.

@tcitworld
Copy link
Member

OK, I think it's an encoding problem with the umlauts. Will try something.

@tcitworld
Copy link
Member

And these 5 articles together always produce a broken EPUB

By which way do you make them together ?

@tcitworld
Copy link
Member

OK, so about the first problem : articles from the Spiegel don't work because the Spiegel refers to an image which doesn't exists :

<noscript>
<img src="http://spiegel.ivwbox.de/cgi-bin/ivw/CP/1006;/politik/deutschland/c-20/r-97/a-973069/be-PB64-cG9saXRpay9hcnRpa2Vs/szwprofil-1006?d=89231600" width="1" height="1" border="0" align="right" id="spIvwPixel" alt="" />
</noscript>

The library wallabag uses still wants to include it, so when the epub is produced, it misses and creates errors. We'll have to check that case.

About the second kind of error, I can't manage to reproduce it. Can you give me more details ? I've tried assigning all of them a common tag, or put them all into a single category.

@tcitworld tcitworld added the Bug label Jun 3, 2014
@tcitworld tcitworld self-assigned this Jun 3, 2014
@tcitworld tcitworld added this to the 1.8.0 milestone Jun 5, 2014
@msone
Copy link
Author

msone commented Jun 6, 2014

Sorry for the late feedback.

Can you give me more details ?

Yes, of course

  • If these 5 articles are unread, the download ist broken.
  • If I move the last two articles to archive, the download from unread is ok and the download from archive is also ok.
  • But if I move the articles from archive back to unread, the epub is corrupt again.
  • If I move them all to archive, the file is also corrupt.
  • If all articles tagged, the file is corrupt.

@tcitworld
Copy link
Member

OK, the problematic article is http://wasmachendieda.de/2014-05-20/markus-trapp-stabstelle-social-media/
If you remove it from your list, you shouldn't have errors anymore.

I've pushed an update to fix this bug in dev branch. It will be available in wallabag 1.7.1, which will only correct some bugs.

@tcitworld
Copy link
Member

First bug is also fixed now.

@msone
Copy link
Author

msone commented Jun 7, 2014

Thank you.

@nicosomb nicosomb modified the milestones: 1.7.1, 1.8.0 Jul 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants