Text colour from article might conflict with theme

[lightonflux]

E.g. If you save an article that has citation in grey text wallabags saves it as grey text, which can conflict with dark themes.

I don't know what the best fix would be. But stripping the text colour information from the text would give a good result.

[tcitworld]

I guess we can make an option for this.
Maybe work this upstream with @fivefilters ? :)

[fivefilters]

I'm assuming this is inline CSS, but I can't be sure - could it be markup that's made grey by Wallabag's own style rules? If it's inline CSS, we don't really do anything special to remove it unless you request &xss=1. That parameter should remove inline CSS through the use of htmLawed. Doesn't Wallabag use HTML Purifier? If it does, then I'm pretty sure you can configure it to remove inline CSS.

[tcitworld]

This is indeed inline CSS for citations blocks, like here. The baggy theme from wallabag uses special rules for blockquote elements, but nothing to do with text color.
I don't think we want to delete all of CSS, though, we just want some rules (delete color font, delete special fonts, blink elements, ...).
I'll look at how does HTML Purifier handles this, since we do use it.
Thanks for reply.

[fivefilters]

Ah ok. In PDF Newspaper and Push to Kindle, we use HTML Purifier to only accept a certain set of HTML elements with only a few attributes allowed - the style attribute is not one of them, so inline CSS doesn't create a problem. In your case, you might want to look at HTMLPurifier_AttrTransform to see if you can change/remove certain style rules that appear in the style attribute without affecting the rest. Haven't attempted this myself, so not sure how easy it is.

[j0k3r]

This seems to be fixed in 2.0.0-alpha.0: http://v2.wallabag.org/view/13