Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the cache time for Flattr checking a setting #765

Closed
tcitworld opened this issue Jul 17, 2014 · 6 comments
Closed

Make the cache time for Flattr checking a setting #765

tcitworld opened this issue Jul 17, 2014 · 6 comments
Assignees
@nicosomb
Labels
Improvement
Milestone
1.9.2

Comments

@tcitworld
Copy link
Member

See this file. I guess maybe some folks wont want too much calls to flattr servers.
@tcitworld tcitworld added this to the 1.8.0 milestone Jul 17, 2014
@nicosomb
Copy link
Member

You're right, we have to enable / disable Flattr.
We also have to review this file (to store "flattr/" into a constant).

@tcitworld
Copy link
Member Author

You're right, we have to enable / disable Flattr

This is already possible. See config file.

@nicosomb
Copy link
Member

So this line https://github.com/wallabag/wallabag/blob/refactor/inc/3rdparty/FlattrItem.class.php#L50 is not called for everyone?
Maybe I didn't understand your issue.

@tcitworld
Copy link
Member Author

You didn't. I was just saying the 86400 number should be a setting, not hardcoded. :)

@nicosomb
Copy link
Member

Ooooh, right.

@tcitworld tcitworld modified the milestones: 1.9.0, 1.8.0 Sep 28, 2014
@tcitworld tcitworld modified the milestones: 1.9.1, 1.9.0 Feb 10, 2015
@tcitworld tcitworld modified the milestones: 1.9.1, 1.9.2 May 22, 2015
@nicosomb
Copy link
Member

nicosomb commented Feb 4, 2016

This issue only affects v1.

@nicosomb nicosomb closed this as completed Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicosomb nicosomb

Labels
Improvement
Projects
None yet
Milestone
1.9.2
Development

No branches or pull requests
2 participants
@nicosomb @tcitworld