Contributing to wallabag and/or site_config

[zinnober]

Hey folks, I did some contributions to site_config on reworking/extending existing templates as well as adding templates for new sites. Except for one initial commit (19438d3) I only contributed to the ftr-site-config repository. My purpose is actually to support wallabag.

I am now not really sure what you would prefer for wallabag: Should I also commit the same changes to the wallabag repository (dev branch)? Or are you merging changes to site_config on aregular basis into wallabag anyway? In that case I'm fine with just submitting to site_config...

What would you prefer?

[zinnober]

Additionally I'd also be happy to help on resolving some of the site_config issues mentioned here before...

[tcitworld]

Well, I've personnally always pushed directly to wallabag's repo, but maybe working directly on @fivefilters repo would be better.

[fivefilters]

I'm biased, so I won't suggest anything. :) But I am still hoping to improve the situation with site config files (automated testing to make sure extraction rules are still valid, and making it easier for users to submit changes).

Zinnober, thanks for contributing to the ftr-site-config repository. I mentioned in issue #627 that in Full-Text RSS's admin area, we give users a URL to an update script which they can poll once a day using a scheduler like cron or similar web-based services. That script pulls in the latest set of site config files from our repository to the user's site_config/standard folder. Users who set that up won't then have to keep the site config folder updated manually. Perhaps there's something similar in Wallabag, but if not, you're welcome to use that script for Wallabag and pull in either from the FiveFilters repository or the Wallabag one.

[zinnober]

@fivefilters: You are very welcome for the contributions and I will - of course - in any case continue to contribute to the site_config repo. Though I myself use the templates exclusively for Wallabag everyone else should be able to profit from them as well... The automated testing you mentioned would definitely make things easier... :)

@tcitworld: The update script mentioned by @fivefilters sounds like a pretty smart solution to me. I'm not so much of a php-coder though, so the implementation would be up to someone else.

Until further notice I suppose I'll continue contributing to the site_config repo then. If you'd like me to push my changes to the Wallabag repo as well just give me a short notice and I'll get my pull requests started... :)

[fivefilters]

We've made a start on the automated testing. More information here: http://blog.fivefilters.org/post/100167407367/extraction-tests-full-text-rss

Test results here: http://siteconfig.fivefilters.org/test/

We've already made a bunch of changes to the site config files (mostly deleting files associated with sites no longer in operation) and will likely do more based on these results. Anyone else is welcome to contribute too. :)

[j0k3r]

The best solution is to commit site_config updates to the official repo: https://github.com/fivefilters/ftr-site-config
Wallabag v2 uses these files.
And we'll think about an automatic update in Wallabag itself (see #1284)