Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content fetching from browser is missing author and pub date #387

Open
johnlago opened this issue Feb 27, 2024 · 3 comments
Open

Content fetching from browser is missing author and pub date #387

johnlago opened this issue Feb 27, 2024 · 3 comments

Comments

@johnlago
Copy link

When using the "Content fetching from the browser" option, Wallabag/Wallabagger seems to consistently not grab an article's author and publication date. Having the Wallabag server fetch the article itself, those fields do fill in.

This article can be used to see the difference: https://www.theverge.com/24064103/video-game-history-foundation-digital-library

@HolgerAusB
Copy link

I am not sure, if the problem is on wallabag or on wallabagger.
Please also see wallabag/wallabag#6972

@charleshan
Copy link

Wallabagger is using Wallabag's APIs so my guess is that it's a problem with Wallabagger.

What steps will reproduce the bug?

Wallabagger > Options > Content fetching from the browser > Enable

When "Content fetching from the browser" is enabled, the author is blank. When "Content fetching from the browser" is disabled, the author is set.

From my experience, it's always better to use "Content fetching from the browser" so I hope we can get this fixed

@charleshan
Copy link

After digging a bit deeper, it's possible that it's a problem with Wallabag...

We should first test if the title is actually set here:
https://github.com/wallabag/wallabagger/blob/3c811e40d555b0cfceffe831728029a3c889066a/wallabagger/js/background.js#L502C1-L505C6

And then check how Wallabag handles the POST request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants