Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorting only work once #130

Closed
pinkal-bacancy opened this issue Oct 15, 2018 · 2 comments
Closed

sorting only work once #130

pinkal-bacancy opened this issue Oct 15, 2018 · 2 comments

Comments

@pinkal-bacancy
Copy link

pinkal-bacancy commented Oct 15, 2018

Hi, @tian-im
sorting is not properly work
suppose i have column in table name and email when i first sort name its work fine but after that if i try to sort any other column in table its not working

I want to feature like one column sort at a time

@tian-im
Copy link
Collaborator

tian-im commented Nov 9, 2018

hey @pinkal-bacancy,

sorry for a late reply.

i've made a note, will see if how i can add the feature in 5.2 and make sorting or sorting implementation configurable.

at the mean while, if you really want that feature, there is a hacky way to do that, but not recommended. it's to replace this helper method sort_link_builder with your own implementation of Wallaby::Sorting::LinkBuilder

cheers,

Tian

@tian-im
Copy link
Collaborator

tian-im commented Nov 28, 2019

As the PR gets merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants