Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested CSS classes are difficult to override #174

Open
ryanb opened this issue Mar 12, 2020 · 1 comment
Open

Nested CSS classes are difficult to override #174

ryanb opened this issue Mar 12, 2020 · 1 comment
Labels

Comments

@ryanb
Copy link

ryanb commented Mar 12, 2020

I find it difficult to customize Wallaby CSS because of the deep nesting. One needs to mimic the nesting in order to add our own CSS.

If CSS is defined in a flat structure then it will be much easier to extend and override.

For example:

# Before
.foo {
  .bar {
  }
}

# After
.foo-bar {
}

Also only adding CSS to classes instead of direct HTML tags will be good too. For example:

# Before
.foo {
  a {
  }
}

# After
.foo-link {
}
@tian-im
Copy link
Collaborator

tian-im commented May 24, 2020

Yeah, that was the ideal structure. Need to spend some time to get it there now. Thanks for bringing this up!

@tian-im tian-im added the wip label May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants