Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing code falls back to ApplicationDecorator #178

Closed
ryanb opened this issue Mar 12, 2020 · 3 comments
Closed

Changing code falls back to ApplicationDecorator #178

ryanb opened this issue Mar 12, 2020 · 3 comments

Comments

@ryanb
Copy link

ryanb commented Mar 12, 2020

I'm getting strange behavior after changing code and reloading the page. Sometimes the code changes don't take effect, but other times it loses reference to the custom decorators and templates.

I've been able to duplicate this on the demo app after upgrading to Wallaby 6. Updating a decorator's code and reloading the page seems to cause all decorators to reference ApplicationDecorator. Also custom templates like views/products/edit.html.erb no longer render instead fall back to their default templates.

Restarting the app fixes the problem until the code changes again.

@tian-im
Copy link
Collaborator

tian-im commented Apr 9, 2020

Yeah, I think this is related to incorrect reload. Let's see if the caching String instead of Class in Wallaby::Map fixes this or not.

@tian-im
Copy link
Collaborator

tian-im commented Apr 12, 2020

@ryanb could you upgrade wallaby to 6.1.2 and see if it works for you?

@ryanb
Copy link
Author

ryanb commented Apr 15, 2020

Yes I believe this is fixed.

@ryanb ryanb closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants