Conflict with closure_tree

[ryanb]

I'm seeing this in our development log:

WALLABY DEBUG: Reloading after Rails' reload...
/Users/rbates/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/closure_tree-7.1.0/lib/closure_tree/support.rb:36: warning: already initialized constant ObjectiveHierarchy
/Users/rbates/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/closure_tree-7.1.0/lib/closure_tree/support.rb:36: warning: previous definition of ObjectiveHierarchy was here
/Users/rbates/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/closure_tree-7.1.0/lib/closure_tree/support.rb:36: warning: already initialized constant OrgNodeHierarchy
/Users/rbates/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/closure_tree-7.1.0/lib/closure_tree/support.rb:36: warning: previous definition of OrgNodeHierarchy was here

It appears Wallaby is loading these classes which closure_tree doesn't expect. I tried adding the classes to Wallaby's exclude config but I still see these warnings. Can you make it so excluding models makes it so Wallaby doesn't attempt to require them?

[tian-im]

Let me double-check if any Class is still stored in Wallaby::Map. Is this issue for envisage?

[ryanb]

Yeah, this is for Envisage. The develop branch.

[ryanb]

Does wallaby attempt to load classes based on database tables? This may be the issue if so.

[tian-im]

Nope, Wallaby only loads the files under eager_load_paths which is the /app folder, it doesn't read the database tables.

Sure, I will take a look.

[tian-im]

@ryanb I can confirm that this is an issue of closure_tree, not wallaby.

I've tried to taken wallaby out completely from the Gemfile, config/routes.rb, config/initializers/wallaby.rb, and if I made any changes to Objective model and visited GET "/objectives", when Rails reloaded, this warning came up. And if you take a look into the list of constants that Rails maintains by using:

ActiveSupport::Dependencies.autoloaded_constants

You will see that Objective is in the list, but the ObjectiveHierarchy created by closure_tree is not captured by Rails Dependencies. Therefore, on every reload, ObjectiveHierarchy will not be removed by Rails before it gets recreated.

[ryanb]

@tian-im oops, sorry about that. I tried removing wallaby as well and was not able to duplicate the warning. I'll close this ticket.

Thanks for taking the time to look into this.

[tian-im]

No worries :)

[ryanb]

FYI, I posted an issue here on closure_tree: ClosureTree/closure_tree#362

[tian-im]

👌