Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't keybind cmd k q in Atom #91

Closed
corysimmons opened this issue Sep 9, 2017 · 3 comments
Closed

Don't keybind cmd k q in Atom #91

corysimmons opened this issue Sep 9, 2017 · 3 comments

Comments

@corysimmons
Copy link

image

It's very easy to miss k then cmd + q quits editor.

@ArtemGovorov
Copy link
Member

ArtemGovorov commented Sep 10, 2017

Hmm, I'm using the keyboard shortcut all the time and had never hit the issue. Also we've have the exact same keyboard shortcut in Quokka for VS Code (where Cmd + Q also quits editor) for 6 months and no-one yet reported it as an issue.

I'm trying to understand the mechanics of how is it possible to "very easy to miss k". If you accidentally hit Cmd + something close to K instead of K, and then Q - the editor obviously won't exit. The issue only shows up if you hit Cmd, and don't hit K at all, and then hit Q. After trying to perform the action a few times, to me it seems not only not very easy, but highly unlikely to happen.

@corysimmons
Copy link
Author

tbh, my keyboard is kinda buggy, every few hits of anything on the right side of keyboard (k, i, etc) just don't register, so if I'm moving quick, I accidentally close editor.

Even if that is my problem, it still seems like something that could happen.

I might be bike-shedding. :|

@ArtemGovorov
Copy link
Member

You may re-assign the keyboard shortcut (for example to Cmd + K, E) like this:

  • open your Atom keymap.cson file (Atom - Keymap),
  • add the following lines to it:
'.platform-darwin atom-text-editor':
  'cmd-k e': 'quokka:make-quokka-from-existing-file'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants