Add Env as argument to source/sink builders #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Particular source and sink implementations (like our Kafka implementations) might need access to `OutStream` for logging purposes. We cannot hold a reference to this in our builders since then they cannot be serialized to send across workers during initialization. This threads Env through the builder apply methods so that we can provide the reference when we are actually building on a particular worker.
slfritchie
approved these changes
Nov 16, 2017
|
@slfritchie Looks like the same one, yeah |
dipinhora
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particular source and sink implementations (like our
Kafka implementations) might need access to
OutStreamfor logging purposes. We cannot hold a reference to this
in our builders since then they cannot be serialized to
send across workers during initialization. This threads
Env through the builder apply methods so that we can
provide the reference when we are actually building on
a particular worker.
Closes #1241