-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using deprecated attrdict library failing with python 3.10 #32
Comments
I believe this can be fixed with this -- |
@wallento I'm getting an increasing amount of reports on this from sphinx plugin users. By looking at the overall activity on the project I understand it isn't actively maintained anymore, but since many people still seem to depend upon it when using it from readthedocs, could the python 3.10 still be supported? Also, is there someone who could take over maintenance of the project? |
Hi, I am happy to pick it up again. Sorry, it seemed to me it was stable and of decreasing use due to the rise of the npm-based version using original wavedrom. Will pick that up asap, but also happy to hand over maintenance to anyone interested. Cheers |
From what I can gather, this is still very useful for rtd users who don't have the option to install npm packages. Not sure if that's going to change anytime soon (have never used the service myself, so don't know for sure) By definition this project will always be behind the officially maintained tool, and I don't think anyone should expect it to always be up to date immediately. So as long as it's not crashing and it's clear what version of upstream wavedrom you're compatible with (I like the idea of https://github.com/wallento/wavedrompy/pull/26/files) I think most users will be happy :) |
Unfortunately there was no interest from upstream wavedrom to coordinate on updates and make them easier to follow, which made it a major occasional reverse engineering effort. On the other hand those major update dumps were rather occasional and I can try to set a day aside to catch up with another version, at least up to picked features that were contributed (like the colors). |
The problem of this merge is solved on master, I will have a look at CI to test if it works and look forward to confirmation too. |
Forgive me, but why is this closed without a corresponding release? I'm currently having to pin my pip install to work around issue bavovanachte/sphinx-wavedrom#38; I'd be grateful for a release, please! |
You can monkeypatch the collections module near the start of your app before the module is imported elsewhere. # Monkey patch collections
import collections
import collections.abc
for type_name in collections.abc.__all__:
setattr(collections, type_name, getattr(collections.abc, type_name)) |
Isn't that solved in 2.0.3-post1? |
The attrdict library is deprecated and use "from collections import Mapping", etc. which has been deprecated in python since 3.3 and is not supported in python 3.10.
The text was updated successfully, but these errors were encountered: