Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] option to set the continuation glyph #94

Closed
nkh opened this issue Jul 19, 2022 · 7 comments
Closed

[Feature Request] option to set the continuation glyph #94

nkh opened this issue Jul 19, 2022 · 7 comments

Comments

@nkh
Copy link

nkh commented Jul 19, 2022

reversed ">" pokes holes in the eye of the beholder

and option to give a continuation string (Eg: "some_ansi_color+...") would be great

@walles
Copy link
Owner

walles commented Jul 19, 2022

Maybe it should simply be replaced entirely.

What would be your suggestion?

@walles
Copy link
Owner

walles commented Jul 19, 2022

And another question, do you think the go-left and the go-right continuation markers should be the same?

Right now they are < and > in inverse video (as you noticed).

Should < and > maybe be highlighted in two separate styles?

@nkh
Copy link
Author

nkh commented Jul 20, 2022

I think that an option is the way to go, you keep to chose the default and "fuzzy" users like me get to chose what they want and in the color they want.

You have a good point with the left/right glyphs, should they be the same,different? the solution would be to give 2 options.

it os slightly more work for you, you need to take the length of the user's string into account (counting the ANSI escape codes, except if you have separate options for the string and the color), but I believe that some of us spend time tweaking their display so it's comfortable to work in for hours.

@walles
Copy link
Owner

walles commented Jul 20, 2022

But what do you think you'd like as a "more contents to the right" indicator?

@nkh
Copy link
Author

nkh commented Jul 20, 2022

I think the indicator (right or left) is a good thing I just want to be able to chose the indicator (I like ellipsis, specially unicode, but one character would be fine) and chose the color so it doesn't poke holes in my eyes at 02:00 hen everything is dark.

@walles
Copy link
Owner

walles commented Jul 21, 2022

  1. Do you have an example file you could attach here where you find the current marker annoying?
  2. Also, when viewing this file, how many characters wide is your terminal window?

@nkh
Copy link
Author

nkh commented Jul 21, 2022

there was a screenshot here where you can see the markers #93

my viewing width varies, my "normal" width is 190 but I use/would use moar in an extra terminal pane via my file manager and the width varies; here's a screenshot when width is minimum

screenshot_2022-07-21_09-17-38

@walles walles closed this as completed in 1faf60d Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants