Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

fix(ops): Limit ECR repo/S3 bucket creation to production only #10

Closed
HarryET opened this issue Jun 30, 2022 · 4 comments
Closed

fix(ops): Limit ECR repo/S3 bucket creation to production only #10

HarryET opened this issue Jun 30, 2022 · 4 comments
Labels
bug Something isn't working ops Terraform

Comments

@HarryET
Copy link
Contributor

HarryET commented Jun 30, 2022

Currently repos are made all the time with no distinction of environment, they should be limited to the prod environment only when multiple environments/workspaces are made.

@HarryET HarryET added bug Something isn't working ops Terraform labels Jun 30, 2022
@HarryET HarryET changed the title fix(ops): Limit ECR repo creation to production only fix(ops): Limit ECR repo/S3 bucket creation to production only Jul 13, 2022
@HarryET
Copy link
Contributor Author

HarryET commented Jul 13, 2022

This should now also limit the S3 bucket to prod only but still allowing access to the bucket's arn and the repo's arn in dev/staging

@HarryET
Copy link
Contributor Author

HarryET commented Jul 13, 2022

# TODO Limit to Prod only
resource "aws_ecr_repository" "gotrue" {
  name                 = "gotrue"
  image_tag_mutability = "MUTABLE"
}

resource "aws_s3_bucket" "cloudsiwe_env" {
  bucket = "cloud-siwe-env"
}

resource "aws_s3_bucket_acl" "cloudsiwe_env_acl" {
  bucket = aws_s3_bucket.cloudsiwe_env.id
  acl    = "private"
}

@arein
Copy link
Member

arein commented Jul 14, 2022

@HarryET
Copy link
Contributor Author

HarryET commented Jul 14, 2022

Closed by #20

@HarryET HarryET closed this as completed Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ops Terraform
Projects
None yet
Development

No branches or pull requests

2 participants