Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions too complicated, add CDN method #13

Closed
fulldecent opened this issue Oct 21, 2018 · 3 comments
Closed

Instructions too complicated, add CDN method #13

fulldecent opened this issue Oct 21, 2018 · 3 comments

Comments

@fulldecent
Copy link
Contributor

Reference: https://docs.walletconnect.org/quick-start#for-web3-provider-web-3-js

yarn and npm install methods are provided. Then documentation recommends the import method.

import isn't even usable in browsers yet. Source: https://caniuse.com/#feat=es6-module-dynamic-import

Instead, the first and simplest example should show how to create a dapp using a JS file included from CDN (including SRI integrity hash).


You are competing with MetaMask. They have a zero-step install process, keep that in mind.

@pedrouid
Copy link
Member

Hi @fulldecent, thanks for the feedback.

However you have to consider that Metamask is a browser extension, that's why it's a zero-step install process. Any other wallet which is not a browser extension will require an install process from the developer. Which is not even common in Web 2.0 integrations, say you wanted to integrate with Twitter, that's not a zero-step install process.

Also most libraries refer to ES6 modules are not implying that majority of browsers support this but that majority of web apps are developed using a bundler like Webpack or Browserify to transpile the code to ES5 for production. This extremely common in front-end development with javascript. But I will take this into account and provide both ES5 and ES6 documentations.

@fulldecent
Copy link
Contributor Author

Thank you for the quick reply. Most people are making applications at lightning speed. "Web design" is including Bootstrap from CDN and copy-pasting code. I hope dapps will be just as convenient.

@pedrouid
Copy link
Member

You can spin-up a webapp with React / Angular / Vue in one CLI command and deploy it right away. NPM packages are more popular than CDN distribution for front-end libraries today. This is not a Dapp specific problem, you will find this with most if not all javascript libraries nowadays. But I will add a CDN distribution in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants